[local_auth] Adopt structured errors and remove useErrorDialogs - platform implementations #10147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
stuartmorgan-g
requested review from
vashworth,
okorohelijah and
mboetger
as code owners
|
This is just #9981 with the changes outside of the platform implementation packages reverted, for separate landing. |
stuartmorgan-g
added
the
federated: partial_changes
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the error handling across Android, Darwin, and Windows platforms to use a new structured LocalAuthException, and removes the deprecated useErrorDialogs option. The changes are comprehensive and well-aligned with the goal of modernizing the error reporting. I've identified a critical compilation issue in the Dart implementation for Darwin and provided a suggested fix. Otherwise, the platform-specific implementations and their corresponding tests are well-executed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platform implementation portion of #9981
LocalAuthExceptionclass for structured errors.AuthenticationOptions.useErrorDialogsPart of:
local_authplugin flutter#113687useErrorDialogsflutter#175125Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3